[PATCH] D108657: [CodeExtractor] Ensuring ordering of exitStub creation

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1268
+
+    Value *brVal = nullptr;
+    switch (NumExitBlocks) {
----------------
AndrewLitteken wrote:
> jroelofs wrote:
> > Should there be an assert:
> > 
> > ```
> > assert(NumExitBlocks < 0xffff && "too many exit blocks for switch");
> > ```
> > 
> > or do you think that's too unlikely to matter?
> I think it's pretty unlikely that there will ever by that many exits out of a function.
👍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108657/new/

https://reviews.llvm.org/D108657