[PATCH] D108428: [ifs] Add option to hide undefined symbols

[Haowei Wu via Phabricator via llvm-commits]

haowei marked 3 inline comments as done.
haowei added a comment.

I forgot to attach the test into git in the previous commit. They were attached int this change.



================
Comment at: llvm/lib/InterfaceStub/IFSHandler.cpp:331
+
+void ifs::stripIFSSymbols(IFSStub &Stub, IFSSymbolType Type, bool Undefined,
+                          bool Weak) {
----------------
mcgrathr wrote:
> It's not clear why this function takes the various arguments since it has only one call site that uses fixed values.
> 
I was plan to make it generic so next time if we need to strip any more symbols based on a different metric, I don't need to write a new function. But I think it does not really matter since it is quite simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108428/new/

https://reviews.llvm.org/D108428