[PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on most platforms

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D107799#2963397 <https://reviews.llvm.org/D107799#2963397>, @phosek wrote:

> I'd prefer moving the header search logic for libc++ into `ToolChain`. There's a comment that says this logic should be handled in subclasses (https://github.com/llvm/llvm-project/blob/b97ca3aca12148bd6ddd0dd78d73003a92f8e553/clang/lib/Driver/ToolChain.cpp#L905) but that leads to a lot of duplication and I'm not sure whether that comment is still relevant. We already have the generic logic for finding the library in `ToolChain` so I don't see why we shouldn't have the header logic there as well. If some platforms need special handling, they can always override the method.

That sounds good to me as long as it doesn't regress any of the drivers in the process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799