[PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on most platforms

Tue Aug 24 13:03:37 PDT 2021

mstorsjo added a comment.

In D107799#2963198 <https://reviews.llvm.org/D107799#2963198>, @MaskRay wrote:

> Ping:)
>
> I'll assume that @mstorsjo has fixed the Windows issues (or I can exclude Windows like Darwin).
>
> Apologies that we want to do this for Linux and can make it a bit inconvenient for Chrome OS (@manojgupta), but we will keep in mind the Linux support for the LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off configuration should not retire.

I've fixed some Windows issues (D107893 <https://reviews.llvm.org/D107893>) but others (D107892 <https://reviews.llvm.org/D107892> and D107895 <https://reviews.llvm.org/D107895>) are still stalled.

The biggest blocker is not fixed in general though: Clang in general does not add the libc++ per-target include directory to its include path. In D89013 <https://reviews.llvm.org/D89013> this was added specifically only to the Gnu and Fuchsia drivers, and D107893 <https://reviews.llvm.org/D107893> added it for the mingw driver. Even for other ELF drivers, like e.g. FreeBSD, the per-target include directory isn't added. See e.g. https://github.com/llvm/llvm-project/blob/204038d52e03811cc39c18cc073c6020fbae4a4b/clang/lib/Driver/ToolChains/FreeBSD.cpp#L405-L409 vs https://github.com/llvm/llvm-project/blob/204038d52e03811cc39c18cc073c6020fbae4a4b/clang/lib/Driver/ToolChains/MinGW.cpp#L591-L602.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799