[PATCH] D106991: [CodeExtractor] Allowing for caller to access final inputs and outputs.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 12:57:52 PDT 2021


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM with documentation nit.



================
Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:142
 
+    Function *extractCodeRegion(const CodeExtractorAnalysisCache &CEAC,
+                                ValueSet &Inputs, ValueSet &Outputs);
----------------
Can you add documentation for `Inputs` and `Outputs` explaining that they are out-params?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106991/new/

https://reviews.llvm.org/D106991



More information about the llvm-commits mailing list