[PATCH] D108601: [SCEV] Infer nsw/nuw from nw for addrecs

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 09:40:08 PDT 2021


reames added a comment.

In D108601#2962661 <https://reviews.llvm.org/D108601#2962661>, @lebedev.ri wrote:

> For the record, this
>
> In D108601#2962217 <https://reviews.llvm.org/D108601#2962217>, @lebedev.ri wrote:
>
>> This does appear correct to me.
>
> isn't approval. There's 'accept revision' for that.
> I'm not sure just how much more softly do i need to word that message to convey that.

Sorry I misread your intent.  It certainly read like approval to me, but well, my screw up.  Reverted, and review resumed.  Will wait for an explicit LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108601/new/

https://reviews.llvm.org/D108601



More information about the llvm-commits mailing list