[PATCH] D108628: [lld/COFF] Improve handling of the /manifestdependency: flag

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 07:23:58 PDT 2021


thakis created this revision.
thakis added reviewers: rnk, mstorsjo, lld.
thakis requested review of this revision.

If multiple /manifestdependency: flags are passed, they are
naively deduped, but after that each of them should have an
effect, instead of just the last one.

Also, /manifestdependency: flags are allowed in .drectve sections
(from `#pragma comment(linker, ...`). To make the interaction between
/manifestdependency: flags enabling manifest by default but
/manifest:no overriding this work, add an explict ManifestKind::Default
state to represent no explicit /manifest flag being passed.
To make /manifestdependency: flags from input file .drectve sections
work with /manifest:embed, delay embedded manifest emission until
after input files have been read.


https://reviews.llvm.org/D108628

Files:
  lld/COFF/Config.h
  lld/COFF/Driver.cpp
  lld/COFF/DriverUtils.cpp
  lld/test/COFF/manifest.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108628.368338.patch
Type: text/x-patch
Size: 9017 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210824/b6cdb455/attachment.bin>


More information about the llvm-commits mailing list