[PATCH] D105807: [X86] pr51000 in-register struct return tailcalling

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/test/CodeGen/X86/sibcall.ll:661
+;; WARNING: This testcase is UB, as the tail call is passed a pointer
+;; to the caller's frame.  It should not be marked tail call.
+
----------------
rnk wrote:
> I dug into the history, and it seems @xbolva00 added this test in a previous attempt to do more TCO around sret. The test is from rG642ed40e57faa34ee3ae7ba0e32f75ff582d408b and the attempt was D46262.
> 
> Honestly, I think you can remove the test. I assumed it had some purpose, but I don't see any motivation for this UB in the review comments.
Feel free to delete it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105807/new/

https://reviews.llvm.org/D105807