[PATCH] D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6088
+    if (!IsFShLegal) {
+      if (isPowerOf2_32(EltSizeInBits)) {
+        FShOpc = RevFsh;
----------------
What if it's not a power of two? In that case, should we fall through to the G_SHL/G_LSHR expansion below?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105347/new/

https://reviews.llvm.org/D105347