[PATCH] D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR

Mateja Marjanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 05:01:11 PDT 2021


matejam added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:5976
+    // If a funnel shift in the other direction is supported, use it.
+    if (!IsFShLegal) {
+      if (isPowerOf2_32(EltSizeInBits)) {
----------------
foad wrote:
> ... so `IsFShLegal` is always true here.
Thanks! :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105347/new/

https://reviews.llvm.org/D105347



More information about the llvm-commits mailing list