[PATCH] D108530: [flang][OpenMP] Fix one bug in parsing depend(sink: vec)

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/include/flang/Parser/parse-tree.h:3439
   TUPLE_CLASS_BOILERPLATE(OmpDependSinkVec);
-  std::tuple<Name, std::optional<OmpDependSinkVecLength>> t;
+  std::tuple<OmpObject, std::optional<OmpDependSinkVecLength>> t;
 };
----------------
In a dependence vector, the names correspond to the iteration variables of loops. While OmpObject can represent variables, it can also represent other things like array expressions, common-blocks etc. Without additional semantics checks this might not be correct, isn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108530/new/

https://reviews.llvm.org/D108530