[PATCH] D108580: [DebugInfo][InstrRef] Fix over-droppage of locations from X86FloatingPoint fixup pass

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

Some nits.



================
Comment at: llvm/lib/Target/X86/X86FloatingPoint.cpp:1041-1042
 
   // Drop all variable values defined by this call -- we can't track them
   // once they've been stackified.
+  if (STReturns)
----------------
Should update the comments?


================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/x86-fp-stackifier-drop-locations.mir:8
+## We shouldn't drop numbers from _every_ call though:
+# CHECK:  CALLpcrel32 @ext, csr_32, implicit $esp, implicit $ssp, implicit-def $esp, implicit-def $ssp, debug-instr-number 101,
 #
----------------
Should check the next CALLpcrel32 dropped debug-instr-number?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108580/new/

https://reviews.llvm.org/D108580