[PATCH] D108432: [InstrProfiling] Keep profd non-private for non-renamable comdat functions

[Rong Xu via Phabricator via llvm-commits]

xur added a comment.

The problem you described is exactly what we wanted to solve with comdat renaming.
We had some correctness issues so I put many restrictions here. We have switched  the default linker to lld
and linkage handling has evolved quite bit.  I might revisit some of
the restrictions again, like if we can enable the renaming for weak linkage.

The problem can happen for regular PGO. As for CSPGO, the instrumentation is post inline 
so the prevailing selection happens before instrumentation. The non-prevailing copy is already 
dropped. I don't this will happen in CSPGO.

Anyway, being conservative is reasonable here. This looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108432/new/

https://reviews.llvm.org/D108432