[PATCH] D108428: [ifs] Add option to hide undefined symbols

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added inline comments.


================
Comment at: llvm/lib/InterfaceStub/IFSHandler.cpp:331
+
+void ifs::stripIFSSymbols(IFSStub &Stub, IFSSymbolType Type, bool Undefined,
+                          bool Weak) {
----------------
It's not clear why this function takes the various arguments since it has only one call site that uses fixed values.



================
Comment at: llvm/lib/InterfaceStub/IFSHandler.cpp:337
+        (Undefined && it->Undefined) || (Weak && it->Weak)) {
+      Stub.Symbols.erase(it);
+    } else {
----------------
phosek wrote:
> You need to update `it` since the iterator will be invalidated by the `erase` operation.
`it = erase(it);` should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108428/new/

https://reviews.llvm.org/D108428