[PATCH] D108520: [MCA] Moving View.h and View.cpp from /tools/llvm-mca/Views/ to /lib/MCA/ and /include/llvm/MCA/.

Patrick Holland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 23 10:59:37 PDT 2021


holland11 added a comment.

Thanks for the feedback. All your suggestions make a lot of sense and I went ahead and implemented them. I went with a `getStartViews()`, `getPostInstrInfoViews()`, and `getEndViews()` since the TimelineView comes at the end anyways. Updated the docs snippet to be more accurate to those 3 variants and also to clarify what you mentioned. Let me know if there's any other feedback that you have. Happy to continue making any modifications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108520/new/

https://reviews.llvm.org/D108520



More information about the llvm-commits mailing list