[PATCH] D106450: [InstCombine] Fold (gep (oneuse(gep Ptr, Idx0)), Idx1) -> (gep Ptr, (add Idx0, Idx1)) (PR51069)

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

In D106450#2960400 <https://reviews.llvm.org/D106450#2960400>, @alexfh wrote:

> In D106450#2956763 <https://reviews.llvm.org/D106450#2956763>, @RKSimon wrote:
>
>> In D106450#2956001 <https://reviews.llvm.org/D106450#2956001>, @alexfh wrote:
>>
>>> In D106450#2955083 <https://reviews.llvm.org/D106450#2955083>, @aeubanks wrote:
>>>
>>>> Given that we have a test case and multiple people have reported regressions, can we revert in the meantime?
>>>
>>> Especially if there's no obvious and clear forward fix, I'd appreciate if you could unblock us by reverting for now. Thanks!
>>
>> Except that regresses other benchmarks that I was addressing with this patch - bullet etc.
>
> Is the regression fixed by this patch more serious than the one introduced by it? Is it clear on how to fix the new regression?

I believe Bullet > “two internal *micro*benchmarks”


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106450/new/

https://reviews.llvm.org/D106450