[PATCH] D108472: [test] Update some test cases to use -passes when specifying the pipeline

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 23 09:44:55 PDT 2021


ctetreau added a comment.

In D108472#2957668 <https://reviews.llvm.org/D108472#2957668>, @nikic wrote:

> I'm not sure doing this is a good idea. The nice thing about the current way of testing is that it works both for the new pass manager and the legacy pass manager. That is, people can flip ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER to false, run the test suite, and get good test coverage for the legacy pass manager. Switching to NewPM-only syntax removes that ability.

How much work would it be to make `--passes='foo,bar'` be equivalent to `-foo -bar` for LPM? Whatever code does this could even complain that LPM is going away and hopefully nudge everyone into working on migrating to NPM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108472/new/

https://reviews.llvm.org/D108472



More information about the llvm-commits mailing list