[PATCH] D108099: [WIP][Attributor] Run Attributor in stages.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 23 08:29:51 PDT 2021


jdoerfert added a comment.

Did you try again and make sure we don't run into a timeout on the iterations?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2441
 
-void Attributor::identifyDefaultAbstractAttributes(Function &F) {
-  if (!VisitedFunctions.insert(&F).second)
-    return;
+void Attributor::identifyFirstStageAttributes(Function &F) {
   if (F.isDeclaration())
----------------
Should we interleave this one and the default one, add an argument to pick which handling the user want? Seems there is some obvious duplication but it might not be as much as I feared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108099/new/

https://reviews.llvm.org/D108099



More information about the llvm-commits mailing list