[PATCH] D108457: [hwasan] Do not instrument accesses to uninteresting allocas.

[Florian Mayer via Phabricator via llvm-commits]

fmayer created this revision.
Herald added a subscriber: hiraditya.
fmayer retitled this revision from "[hwasan] Do not instrument accesses to safe allocas." to "[hwasan] Do not instrument accesses to uninteresting allocas.".
fmayer updated this revision to Diff 367778.
fmayer added a comment.
fmayer updated this revision to Diff 367790.
fmayer edited the summary of this revision.
fmayer edited the summary of this revision.
fmayer updated this revision to Diff 367842.
fmayer updated this revision to Diff 368055.
fmayer updated this revision to Diff 368113.
fmayer updated this revision to Diff 368116.
fmayer updated this revision to Diff 368118.
fmayer published this revision for review.
fmayer added a reviewer: eugenis.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

better test.


fmayer added a comment.

ignore all alloca access if stack not instrumented


fmayer added a comment.

better variable naming.


fmayer added a comment.

add test


fmayer added a comment.

allow to control strictness of alloc matching


fmayer added a comment.

format


fmayer added a comment.

remove comment


This leads to a statistically significant improvement when using -hwasan-instrument-stack=0: https://bit.ly/3AZUIKI.
When enabling stack instrumentation, the data appears gets better but not statistically significantly so. This is consistent
with the very moderate improvements I have seen for stack safety otherwise, so I expect it to improve when the underlying
issue of that is resolved.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108457

Files:
  llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
  llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108457.368118.patch
Type: text/x-patch
Size: 5523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210823/8fc2e0c9/attachment.bin>