[PATCH] D108559: Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType

Chih-Ping Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 23 08:18:18 PDT 2021


cchen15 created this revision.
cchen15 added reviewers: aprantl, shchenz, LiuChen3.
Herald added a subscriber: hiraditya.
cchen15 requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

It turns out that the optimizations may correctly encode a Fortran character object as an integer even when the character length is greater than 1.

Also, it is probably not the AsmPrinter's job to catch the result of a bad transformation, which the removed assertion appears to be doing.

This is a follow-up to https://reviews.llvm.org/D100015.


https://reviews.llvm.org/D108559

Files:
  llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
  llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108559.368112.patch
Type: text/x-patch
Size: 7198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210823/281d1d3e/attachment.bin>


More information about the llvm-commits mailing list