[PATCH] D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 23 00:08:52 PDT 2021
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:516-520
+ if (StrIndex % 3 == 1)
+ OS << " ";
+ OS << left_justify(CurrentStr, BaseWidth) << " ";
+ if (StrIndex % 3 == 2)
+ OS << "\n";
----------------
1) You don't want to justify/add trailing spaces on the last column - there's no point.
2) You can simplify this code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106643/new/
https://reviews.llvm.org/D106643
More information about the llvm-commits
mailing list