[PATCH] D108315: [AMDGPU] Add alias.scope metadata to lowered LDS struct

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D108315#2953690 <https://reviews.llvm.org/D108315#2953690>, @JonChesterfield wrote:

> Change looks good but this comment is strange:
>
>   // Create alias.scope and their lists. Each field in the new structure
>   // does not alias with all other fields.
>
> That is true of any structure. Each s/field/pointer in the new?
>
> It seems a shame that moving variables into a struct thwarts AA at present.

I.e. to the defence of the comment:

struct { int a; int b; } object;
memset(&object.a, 0, sizeof(object));

This case only references the first field and yet clobbers the entire struct. So the "pointer" is not a right word here. Pointer and an access size is, which is... a field in our case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108315/new/

https://reviews.llvm.org/D108315