[PATCH] D108315: [AMDGPU] Add alias.scope metadata to lowered LDS struct

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 15:24:19 PDT 2021


rampitec planned changes to this revision.
rampitec added a comment.

I have realized scope.alias metadata is not well formed. It shall be a list of scopes, not a scope itself even if the list consists of a single scope. Even though it works it is incorrect.
Then if that is a list normal merging shall work properly.
In addition I think that concatentate is right for this specific case, we are not creating new aliasing by the transformation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108315/new/

https://reviews.llvm.org/D108315



More information about the llvm-commits mailing list