[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 17 11:06:14 PDT 2021
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12195
+ if (!fpModeMatchesGlobalFPAtomicMode(RMW))
+ return reportUnsafeHWInst(RMW, AtomicExpansionKind::None);
----------------
gandhi21299 wrote:
> rampitec wrote:
> > rampitec wrote:
> > > This is wrong. Condition is inverted and essentially tests should fail. Make sure you can pass testing before posting a diff.
> > Unresolved.
> Remarks are produced if `fpModeMatchesGlobalFPAtomicMode(RMW) == false`
But you have changed what function was doing. It was returning CmpXChg.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108150/new/
https://reviews.llvm.org/D108150
More information about the llvm-commits
mailing list