[PATCH] D107421: [yaml2obj][XCOFF] Customize the string table.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added a comment.

The codes generally looks good to me.



================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:59
   yaml::ErrorHandler ErrHandler;
-  StringTableBuilder Strings;
+  StringTableBuilder StrTbl;
   uint64_t StartOffset;
----------------
Might be good to rename `StrTbl` to `StrTblBuilder` or something else to distinguish it from `Obj.StrTbl`.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:399
+  StrTbl.write(Ptr);
+  // Overwrite the first 4-bytes with the specified length value.
+  memset(Ptr, 0, 4);
----------------
Nit: first 4-bytes -> first 4-byte


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107421/new/

https://reviews.llvm.org/D107421