[PATCH] D108512: [flang][OpenMP] Add semantic check for ordered construct

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added a subscriber: kiranktp.
kiranchandramohan added a comment.
This revision now requires changes to proceed.

There is a similar patch (https://reviews.llvm.org/D94087) from @sameeranjoshi (AMD) which implements these constraints. Please go through the discussion in that patch. Also,

@kiranktp is it OK if @peixin proceed with this patch. He can use the D94087 <https://reviews.llvm.org/D94087> as a reference and take it to completion. Peixin can add @sameeranjoshi as a co-author.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:762
 
+void OmpStructureChecker::CheckAllowedOnceClause(
+    const llvm::omp::Clause clause) {
----------------
You can use the allowedOnce specification in OMP.td to achieve this. Change allowedClauses to allowedOnceClauses for Ordered.
https://github.com/llvm/llvm-project/blob/79b55e5038324e61a3abf4e6a9a949c473edd858/llvm/include/llvm/Frontend/OpenMP/OMP.td#L491


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108512/new/

https://reviews.llvm.org/D108512