[PATCH] D108476: [runtimeunroll] Support epilogue unrolling with a parent loop
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 22 13:13:11 PDT 2021
reames added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp:451
- // FIXME: We bail out of multi-exit unrolling when epilog loop is generated
- // and L is an inner loop. This is because in presence of multiple exits, the
- // outer loop is incorrect: we do not add the EpilogPreheader and exit to the
- // outer loop. This is automatically handled in the prolog case, so we do not
- // have that bug in prolog generation.
- if (UseEpilogRemainder && L->getParentLoop())
+ // FIXME: CloneLoopBlocks doesn't correctly update loopinfo for epilogue
+ // blocks which are outside the outer loop because we broke the inner
----------------
FYI, this FIXME can be removed when D108521 has been landed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108476/new/
https://reviews.llvm.org/D108476
More information about the llvm-commits
mailing list