[PATCH] D107474: [AMDGPU] Better legalization of ctlz/cttz

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2542
                           ? AMDGPU::G_AMDGPU_FFBH_U32
-                          : AMDGPU::G_AMDGPU_FFBL_B32;
-    unsigned Idx = Opc == AMDGPU::G_CTLZ_ZERO_UNDEF;
+                          : Opc == AMDGPU::G_CTLZ_ZERO_UNDEF
+                                ? AMDGPU::G_AMDGPU_FFBL_B32
----------------
RKSimon wrote:
> @foad Coverity is complaining that you've repeated the 'Opc == AMDGPU::G_CTLZ_ZERO_UNDEF' check (which is dead code) - should the second one be 'Opc == AMDGPU::G_CTTZ_ZERO_UNDEF' ?
Yes, and I see you fixed it in D108210 - thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107474/new/

https://reviews.llvm.org/D107474