[llvm] a83d99c - [TargetMachine] Drop special case for *-win32-macho

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 21 13:59:26 PDT 2021


Author: Fangrui Song
Date: 2021-08-21T13:59:17-07:00
New Revision: a83d99c55ebb14532c414066a5aa3bdb65389965

URL: https://github.com/llvm/llvm-project/commit/a83d99c55ebb14532c414066a5aa3bdb65389965
DIFF: https://github.com/llvm/llvm-project/commit/a83d99c55ebb14532c414066a5aa3bdb65389965.diff

LOG: [TargetMachine] Drop special case for *-win32-macho

clang CodeGenModule shouldAssumeDSOLocal has set dso_local.

Added: 
    

Modified: 
    llvm/lib/Target/TargetMachine.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/TargetMachine.cpp b/llvm/lib/Target/TargetMachine.cpp
index 86cb30d4eb8f..32bdb71b4532 100644
--- a/llvm/lib/Target/TargetMachine.cpp
+++ b/llvm/lib/Target/TargetMachine.cpp
@@ -140,12 +140,6 @@ bool TargetMachine::shouldAssumeDSOLocal(const Module &M,
   }
 
   if (TT.isOSBinFormatMachO()) {
-    // Make an exception for windows OS in the triple: Some firmware builds use
-    // *-win32-macho triples. This (accidentally?) produced windows relocations
-    // without GOT tables in older clang versions; Keep this behaviour.
-    if (TT.isOSWindows())
-      return true;
-
     if (RM == Reloc::Static)
       return true;
     return GV->isStrongDefinitionForLinker();


        


More information about the llvm-commits mailing list