[PATCH] D107822: [InstCombine] Fold Int2Ptr/PtrToInt if the ptr is dereferenceable
Krishna Kariya via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 21 02:38:29 PDT 2021
Krishnakariya added a comment.
In D107822#2956860 <https://reviews.llvm.org/D107822#2956860>, @lebedev.ri wrote:
> The code here looks very weird.
> Please can you at least split this up into a preparatory NFC changes, the deref-based fold, and the domination-based fold?
> Also, please precommit the tests, even if just locally for you, so that the patches show how the check lines change.
Splited this patch into 3 parts: D108504 <https://reviews.llvm.org/D108504> (NFC), D108506 <https://reviews.llvm.org/D108506> (deref-based fold), and this one (dominator-based fold). Added precommit tests also.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107822/new/
https://reviews.llvm.org/D107822
More information about the llvm-commits
mailing list