[PATCH] D108353: [loop-idiom] Support memcpy instructions for memmove-like loops

Fri Aug 20 17:01:46 PDT 2021

zhuhan0 added a comment.

In D108353#2954114 <https://reviews.llvm.org/D108353#2954114>, @yurai007 wrote:

> @zhuhan0: Thanks for following up my memmove change! Actually there is analogous follow up but it didn't catch lot of attention: https://reviews.llvm.org/D107075.
> Maybe you can reuse some parts of that change. I feel you could at least copy most unit tests from there for better coverage. 
> And last but not least - there is one ongoing small but important fix for https://reviews.llvm.org/D104464 which can be found here: https://reviews.llvm.org/D107964
> It would be great if you and @hoy could take a look since your changes depends on it.

Oops I didn't know had a follow-up patch already! Is it really okay for me to copy your diff? I can also review your diff and land that. Which do you prefer?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108353/new/

https://reviews.llvm.org/D108353