[PATCH] D108495: [Bazel] Reduce quote escaping

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 20 16:30:22 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:347
+    cmd = (
+        "echo '#define CLANG_VERSION 12.0' >> $@\n" +
+        "echo '#define CLANG_VERSION_MAJOR 12' >> $@\n" +
----------------
BTW, it is 14.0.0 now. The change should be separate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108495/new/

https://reviews.llvm.org/D108495



More information about the llvm-commits mailing list