[PATCH] D108435: [CSSPGO] split context string II - reader/writer changes

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:506
+ErrorOr<SampleContext>
+SampleProfileReaderBinary::readNameFromTable(bool IsContextName) {
+  auto FName(readStringFromTable());
----------------
hoy wrote:
> wmi wrote:
> > This param is unused. Write it as readNameFromTable(bool /* IsContextName */) to make it more explicit. 
> Sounds good.
Actually I can only do that in the header file for the function declaration. The function definition needs a real name for param.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108435/new/

https://reviews.llvm.org/D108435