[PATCH] D108480: Fix DWARFDie::getDeclFile(...) to work with DW_AT_specification.

Fri Aug 20 14:43:11 PDT 2021

dblaikie added a comment.

Given the textual overhead of DWARF unit test yaml at the moment, I think it might be reasonable to put the various examples in one test file/one YAML rather than multiple separate tests with all the overhead of describing standalone DWARF in each test. Or, at least, trimming them down substantially to just the bare necessities.

================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp:114-135
+          Children:        DW_CHILDREN_yes
+          Attributes:
+            - Attribute:       DW_AT_name
+              Form:            DW_FORM_strp
+            - Attribute:       DW_AT_language
+              Form:            DW_FORM_udata
+            - Attribute:       DW_AT_stmt_list
----------------
Could probably strip most of this out - keep just the DW_TAG_compile_unit's DW_AT_stmt_list, and the DW_TAG_subprogram's DW_AT_decl_file?

================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp:174-202
+        - Opcode:          DW_LNS_extended_op
+          ExtLen:          9
+          SubOpcode:       DW_LNE_set_address
+          Data:            4096
+        - Opcode:          DW_LNS_advance_line
+          SData:           9
+          Data:            0
----------------
Can this all be stripped, or does it have to be here for some reason? (maybe it can just be the single end_sequence?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108480/new/

https://reviews.llvm.org/D108480