[PATCH] D108416: [WORK IN PROGRESS][llvm-libgcc] initial commit

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:68
+
+.. option:: `LLVM_LIBGCC_TARGET`
+
----------------
Does `LLVM_DEFAULT_TARGET_TRIPLE` help?


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:183
+
+  $ readelf -su "${LLVM_LIBGCC_SYSROOT}/lib/libunwind.so" | grep FUNC | grep GCC_3.0
+
----------------
`readelf -W --dyn-syms`


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:186
+
+Roughly sixty symbols should appear, all suffixed with ``@@GCC_3.0``. You can
+replace ``GCC_3.0`` with any of the supported version names in the version
----------------
There are many symbols of other versions.


================
Comment at: llvm/libgcc/lib/CMakeLists.txt:3
+
+add_library(unwind_shared SHARED blank.cpp)
+set_target_properties(unwind_shared
----------------
The name "unwind" may be confused with llvm-project/libunwind


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416