[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 20 09:36:25 PDT 2021


peter.smith updated this revision to Diff 367814.
peter.smith retitled this revision from "[MC] Add MCSubtargetInfo to MCAlignFragment [NFC]" to "[MC] Add MCSubtargetInfo to MCAlignFragment".
peter.smith edited the summary of this revision.
peter.smith added a comment.

Rebased patch (sorry for the delay). I've added fixup code for the interface change to InitSections for clang and one of the unit tests. I've also removed the [NFC] as this will likely break a lot of downstream tools using MC.

An alternative implementation that is less disruptive would make the MCSubtargetInfo an optional parameter that could be nullptr but that would mean that we'd need to test in emitNops whether the MCSubtargetInfo is nullptr which is not ideal but it may lead to a much smaller patch for this and D45962 <https://reviews.llvm.org/D45962>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45961/new/

https://reviews.llvm.org/D45961

Files:
  clang/tools/driver/cc1as_main.cpp
  llvm/include/llvm/MC/MCELFStreamer.h
  llvm/include/llvm/MC/MCFragment.h
  llvm/include/llvm/MC/MCObjectStreamer.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/include/llvm/MC/MCWinCOFFStreamer.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/MC/ConstantPools.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCObjectStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
  llvm/lib/Target/ARM/ARMAsmPrinter.cpp
  llvm/lib/Target/ARM/ARMMCInstLower.cpp
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
  llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp
  llvm/lib/Target/Hexagon/HexagonTargetStreamer.h
  llvm/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
  llvm/lib/Target/Mips/MipsAsmPrinter.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFStreamer.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFStreamer.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/lib/Target/X86/X86MCInstLower.cpp
  llvm/tools/llvm-mc/Disassembler.cpp
  llvm/tools/llvm-mc/llvm-mc.cpp
  llvm/tools/llvm-ml/Disassembler.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45961.367814.patch
Type: text/x-patch
Size: 28201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210820/9fa51a05/attachment.bin>


More information about the llvm-commits mailing list