[PATCH] D108372: [X86][SchedModels] Fix missing ReadAdvance for MULX and ADCX/ADOX (PR51494)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Just checking: we don't have this problem with `SBB`?

In D108372#2957412 <https://reviews.llvm.org/D108372#2957412>, @RKSimon wrote:

> @lebedev.ri Are you OK with the znver changes?

znver3 seems fine, thanks.



================
Comment at: llvm/lib/Target/X86/X86ScheduleZnver3.td:631
   let Latency = !add(Znver3Model.LoadLatency, Zn3MULX32rr.Latency);
   let ResourceCycles = [1, 1, 2];
   let NumMicroOps = Zn3MULX32rr.NumMicroOps;
----------------
RKSimon wrote:
> its weird that the rm variant uses the Zn3Multiplier pipe for an extra cycle......
Yes, but i'm pretty sure this is not a typo.
There might be modelling problems in mca/exegesis, so it //might// be spurious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108372/new/

https://reviews.llvm.org/D108372