[PATCH] D108112: [LoopIdiom] let LIR fold memset pointer / stride SCEV regarding loop guards
Bardia Mahjour via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 20 07:46:00 PDT 2021
bmahjour added a comment.
I still have some reservations about the SCEVFolder implementation in this patch. It doesn't really fold anything, it just zero extends an expression if it is safe to do so. The assumption being made is that the expression it compares against is unsigned. In the LIT test provided the trip count is zero extended by loop simplify because it is originally 32-bit and the code is targeting 64-bit mode. But what if we are compiling in 32-bit mode, or if 'n' and 'm' where 'signed long long'?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108112/new/
https://reviews.llvm.org/D108112
More information about the llvm-commits
mailing list