[PATCH] D108455: Replacing recursion by cycle in file "SimplifyCFG.cpp", removing the deprecated option.

[Dmitry Bakunevich via Phabricator via llvm-commits]

dbakunevich added a comment.

In D108455#2957051 <https://reviews.llvm.org/D108455#2957051>, @nikic wrote:

> This is not what the TODO is about. The TODO is about not visiting operands repeatedly if they occur multiple times.



In D108455#2957067 <https://reviews.llvm.org/D108455#2957067>, @lebedev.ri wrote:

> I will hopefully soon post a patch that removes `dominatesMergePoint()`, it's just wrong so i'm not sure it's worth improving it.

I realized that I misunderstood this "todo". It is necessary to add another "SmallPtrSet", which will keep track of set unique elements.

Does it make sense to make these changes or wait for "dominatesMergePoint ()" to be removed in the future?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108455/new/

https://reviews.llvm.org/D108455