[PATCH] D106056: [CVP] processSwitch: Remove default case when switch cover all possible values.
JunMa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 20 02:54:10 PDT 2021
junparser added a comment.
In D106056#2955440 <https://reviews.llvm.org/D106056#2955440>, @nathanchance wrote:
> @junparser I am not convinced this is a bug in `objtool`. @spatel 's comment makes me wonder if one of the other switch cases is becoming just `return false` because LTO allows LLVM to see that one of the `if (max_contiguous < ...)` checks is always true then this transform removes both that case and the default case because they are equivalent, which seems to be inline with what `objtool` is warning about. I am more than happy to test follow up versions of this patch as I am subscribed, feel free to ping me as well.
@spatel @nathanchance , we can fix PR51531 now and kernel boot still failed. However, When I change **default: return false** to **default: unreachable()**, the boot also failed with thinlto. @nathanchance, can we have something reduced for us to debug?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106056/new/
https://reviews.llvm.org/D106056
More information about the llvm-commits
mailing list