[PATCH] D108187: [RISCV] Rename FeatureStdExtZvlsseg to FeatureExtZvlsseg
Jim Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 19 19:12:48 PDT 2021
Jim marked an inline comment as done.
Jim added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCV.td:177
+def FeatureExtZvlsseg
: SubtargetFeature<"experimental-zvlsseg", "HasStdExtZvlsseg", "true",
"'Zvlsseg' (Vector segment load/store instructions)",
----------------
craig.topper wrote:
> This patch makes things consistent, but I'm not sure why the bools in RISCVSubtarget.h have "Std" in their name.
The bools have prefix hasStdExt*. All of sub-extensions are all the same.
Or the SubtargetFeatures should be fixed to have prefix FeatureStdExt* for all of sub-extension.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108187/new/
https://reviews.llvm.org/D108187
More information about the llvm-commits
mailing list