[PATCH] D108432: [InstrProfiling] Don't make non-renamable {weak,linkonce}{,_odr} profd private
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 19 18:41:27 PDT 2021
MaskRay added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:958
// to be false.
- if (NS == 0 && (TT.isOSBinFormatELF() ||
- (!DataReferencedByCode && TT.isOSBinFormatCOFF()))) {
+ if (NS == 0 && !(Fn->GlobalValue::hasComdat() && !canRenameComdatFunc(*Fn)) &&
+ (TT.isOSBinFormatELF() ||
----------------
canRenameComdatFunc should check whether the variable is actually renamed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108432/new/
https://reviews.llvm.org/D108432
More information about the llvm-commits
mailing list