[PATCH] D108341: [WebAssembly] More convert_low and promote_low codegen

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

I'm seeing narrowing diagnostic failures from this:

  llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1840:33: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'int' in initializer list [-Wc++11-narrowing]
                                 {LHSIndex, RHSIndex + 4, -1, -1});
                                  ^~~~~~~~
  llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1840:33: note: insert an explicit cast to silence this issue
                                 {LHSIndex, RHSIndex + 4, -1, -1});
                                  ^~~~~~~~
                                  static_cast<int>( )
  llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1840:43: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'int' in initializer list [-Wc++11-narrowing]
                                 {LHSIndex, RHSIndex + 4, -1, -1});
                                            ^~~~~~~~~~~~
  llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1840:43: note: insert an explicit cast to silence this issue
                                 {LHSIndex, RHSIndex + 4, -1, -1});
                                            ^~~~~~~~~~~~
                                            static_cast<int>( )

Could you please look into a fix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108341/new/

https://reviews.llvm.org/D108341