[PATCH] D108332: Have lit preserve SOURCE_DATE_EPOCH

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 15:16:44 PDT 2021


tstellar added a comment.

In D108332#2955970 <https://reviews.llvm.org/D108332#2955970>, @dblaikie wrote:

> In D108332#2955923 <https://reviews.llvm.org/D108332#2955923>, @serge-sans-paille wrote:
>
>>> Though this change would only have an effect on the test behavior, right? Is that a problem for some build systems? I know some are really pedantic about reproducibility even of the test results, but haven't seen any that pedantic outside of Google (& probably Facebook) - and at least at Google I don't think we've hit this, perhaps because we don't build zlib with that hardware support?
>>
>> That seems to be specific to SystemZ, which may not be used at Google / Facebook (?)
>
> Yeah, I don't think it is - but it was specifically the overlap of SystemZ and a pedantically strict build system (that requires/values bit-identical reproducibility even for test artifacts). Do you have experience with such a build system that motivated this change?

It's not the build system that's being pedantic here, it is the reference output in the clang test cases:

FAIL: Clang :: Modules/embed-files-compressed.cpp (8052 of 29120)
FAIL: Clang :: Modules/stress1.cpp (8330 of 29120)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108332/new/

https://reviews.llvm.org/D108332



More information about the llvm-commits mailing list