[PATCH] D106228: [LTO] Add SelectionKind to IRSymtab and use it in ld.lld/LLVMgold

Thu Aug 19 15:15:59 PDT 2021

steplong added inline comments.

================
Comment at: llvm/test/tools/gold/X86/comdat-nodeduplicate.ll:40
+; RUN:   -u foo %t/a.bc --start-lib %t/b.bc %t/c.bc --end-lib -o %t/abc
+; RUN: llvm-readelf -x .data %t/abc | FileCheck %s --check-prefix=DATA
+
----------------
MaskRay wrote:
> steplong wrote:
> > Hi, I'm seeing a test failure on amd64 with this line. The actual output I'm seeing is
> > `DATA: 0x[[#%x,]] 01000000 00000000 02000000 00000000 ........`. I don't know enough about the patch to determine what is going on. I wonder if you have any ideas.
> I suspect it is a bug in older gold.
> 
> My `llvm-readelf -x .data` output with binutils 2.35.2 and (built from git) 2.36.50.2021.0520
> ```
> 
> Hex dump of section '.data':
>   0x00401128 01000000 00000000                   ........
> 
> ```
> 
> What's your version? If it's not too much a hassle, I hope we just accept it and don't do anything. The test will be good when your gold is upgraded..
We are using
```
$ ld.gold -version
GNU gold (GNU Binutils for Ubuntu 2.24) 1.11
```
and yup should be ok to just accept it as it is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106228/new/

https://reviews.llvm.org/D106228