[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:9
+// RUN:     -fsanitize=address %s -fsanitize-address-outline-instrumentation \
+// RUN:     -mllvm -asan-optimize-callbacks \
+// RUN:     | FileCheck %s --check-prefixes=CHECK-OPTIMIZED
----------------
vitalybuka wrote:
> for -mllvm flag we need test under llvm/test not clang.
> 
> llvm test needs to be more meaningful, e.g. check precice value passed into intrinsic
> and have 3 versions:
> ... -mllvm -asan-optimize-callbacks=0
> ... -mllvm -asan-optimize-callbacks=1
> ... default
to clarify
Goal of clang/test/CodeGen/asan-use-callbacks.cpp to test -fsanitize-address-outline-instrumentation which is frontend (clang) flag.
-mllvm are not clang flags, even clang knows how to forward them to llvm.

I believe we will not add corresponding frontend clang flag for asan-optimize-callbacks. We will make it default ON after some testing and benchmarking.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108377/new/

https://reviews.llvm.org/D108377