[PATCH] D108399: [LoopPassManager] Assert that MemorySSA is preserved if used

[Nikita Popov via Phabricator via llvm-commits]

nikic updated this revision to Diff 367602.
nikic added a comment.
Herald added a subscriber: ormris.

Add test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108399/new/

https://reviews.llvm.org/D108399

Files:
  llvm/lib/Transforms/Scalar/LoopPassManager.cpp
  llvm/test/Other/loop-mssa-not-preserved.ll


Index: llvm/test/Other/loop-mssa-not-preserved.ll
===================================================================
--- /dev/null
+++ llvm/test/Other/loop-mssa-not-preserved.ll
@@ -0,0 +1,17 @@
+; RUN: not --crash opt -passes='loop-mssa(loop-unroll-full)' 2>&1 < %s | FileCheck %s
+
+; CHECK: LLVM ERROR: Loop pass manager using MemorySSA contains a pass that does not preserve MemorySSA
+
+define void @test() {
+entry:
+  br label %loop
+
+loop:
+  %i = phi i32 [ 0, %entry ], [ %i.inc, %loop ]
+  %i.inc = add i32 %i, 1
+  %c = icmp ult i32 %i, 8
+  br i1 %c, label %loop, label %exit
+
+exit:
+  ret void
+}
Index: llvm/lib/Transforms/Scalar/LoopPassManager.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopPassManager.cpp
+++ llvm/lib/Transforms/Scalar/LoopPassManager.cpp
@@ -285,6 +285,10 @@
     else
       PI.runAfterPass<Loop>(*Pass, *L, PassPA);
 
+    if (LAR.MSSA && !PassPA.getChecker<MemorySSAAnalysis>().preserved())
+      report_fatal_error("Loop pass manager using MemorySSA contains a pass "
+                         "that does not preserve MemorySSA");
+
 #ifndef NDEBUG
     // LoopAnalysisResults should always be valid.
     // Note that we don't LAR.SE.verify() because that can change observed SE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108399.367602.patch
Type: text/x-patch
Size: 1285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210819/9eeab852/attachment.bin>