[PATCH] D108381: [hwasan] re-enable stack safety by default.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 13:10:13 PDT 2021


fmayer updated this revision to Diff 367598.
fmayer added a comment.

test that stack safety defaults on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108381/new/

https://reviews.llvm.org/D108381

Files:
  llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
  llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll


Index: llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll
===================================================================
--- llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll
+++ llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll
@@ -1,5 +1,6 @@
 ; RUN: opt -hwasan -hwasan-use-stack-safety=1 -hwasan-generate-tags-with-calls -S < %s | FileCheck %s --check-prefixes=SAFETY
 ; RUN: opt -hwasan -hwasan-use-stack-safety=0 -hwasan-generate-tags-with-calls -S < %s | FileCheck %s --check-prefixes=NOSAFETY
+; RUN: opt -hwasan -hwasan-generate-tags-with-calls -S < %s | FileCheck %s --check-prefixes=SAFETY
 
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-unknown-linux-gnu"
Index: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
+++ llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
@@ -115,7 +115,7 @@
                                        cl::Hidden, cl::init(true));
 
 static cl::opt<bool>
-    ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(false),
+    ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(true),
                      cl::Hidden, cl::desc("Use Stack Safety analysis results"),
                      cl::Optional);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108381.367598.patch
Type: text/x-patch
Size: 1435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210819/3b44cf63/attachment.bin>


More information about the llvm-commits mailing list