[PATCH] D108332: Have lit preserve SOURCE_DATE_EPOCH

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

In D108332#2953931 <https://reviews.llvm.org/D108332#2953931>, @serge-sans-paille wrote:

> In D108332#2953877 <https://reviews.llvm.org/D108332#2953877>, @dblaikie wrote:
>
>> What sort of use would we have for this variable inside lit tests?
>
> Some llvm and clang tests rely on compression through zlib (e.g. when testing compressed debug info). In some case, compression output may differ, e.g. when some hardware acceleration happen (see https://github.com/madler/zlib/pull/410) and that issue can be mitigated by setting SOURCE_DATE_EPOCH

oh, neat - good to know!

Though this change would only have an effect on the test behavior, right? Is that a problem for some build systems? I know some are really pedantic about reproducibility even of the test results, but haven't seen any that pedantic outside of Google (& probably Facebook) - and at least at Google I don't think we've hit this, perhaps because we don't build zlib with that hardware support?

(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108332/new/

https://reviews.llvm.org/D108332