[PATCH] D107299: [CSSPGO] Split context string to deduplicate function name used in the context.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D107299#2955079 <https://reviews.llvm.org/D107299#2955079>, @wmi wrote:

> Thanks Hongtao. The compile time result looks great. The patch is large. Is it possible to split it into smaller ones, SampleContext related change and SecCSNameTable related change for example?

Thanks for the suggestion. The separation may not be complete. The point is that the previous `StringRef` context is used in both reader/writer, and now we are changing it to be an `ArrayRef` which relies on an underlying array buffer (i.e., the `CSName` the reader builds up). Separating SecCSNameTable from this patch will still require the reader to build the underlying `CSName` table to bridge full string contexts in profile to `ArrayRef` contexts used elsewhere. Does this sound good to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107299/new/

https://reviews.llvm.org/D107299